Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5884] New: CORRECTED EXPORT_OBJECT SMB SEGMENTATION FAULT

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5884

           Summary: CORRECTED EXPORT_OBJECT SMB SEGMENTATION FAULT
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: jose.pico@xxxxxxxxx


Created an attachment (id=6275)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6275)
Patch file

Build Information:
wireshark 1.5.2 (SVN Rev 36962 from /trunk)
--
(See discussion in bug 5337 for previous comments about this bug)

- Removed "visited packet" code, because it seems to be unuseful
- Removed the verification of eo_info=null, because it seems to be unseful
- Corrected the segmentation fault caused when the export_object window is
opened and the user opens a new capture file (see below).

EXPLANATION OF THE BUG AND THE CHOOSEN SOLUTION:
When any export_object_xxx functionality needs private data structures to
construct export_object entries (of the type export_object_entry_t), these
private data structures need to be initialized (cleaned) whenever a eo_reset
occurs in the export_object window or the windows is closed. This is the case
of the export_object_smb functionality, and in general of any (future)
functionality that needs to keep track of data distributed randomly accross a
wireshark capture. We've modified the export_object_window function call by
adding a parameter, which is the function address that performs this
initialization task, so that every time the export_object_window is called,
this function must be provided if needed, or NULL otherwise (export_object_http
and export_object_dicom now pass NULL in this position). This way the
export_object_smb error is corrected and minimal modifications have been made
to export_object_http and export_object_dicom modules.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.