Wireshark-bugs: [Wireshark-bugs] [Bug 5868] USB-encapsulated AT/Hayes Commands dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5868
--- Comment #12 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-04-28 13:46:03 PDT ---
(In reply to comment #9)
> In fact, shouldn't it be called "packet-usb-at" - unless someone comes along
> and generalises it, later?
Um, sure!
> The general approach that I'm using is that of the PPP dissector, and the
> Ethernet enhancements patch in bug 4819.
My comments about the patch I submitted in bug 4819 indicate that it breaks bug
4810, so I'm not sure we can use it. Honestly, I don't remember much about
these patches now, so I'd have to go back and review everything.
> I was unaware of check_col() being deprecated - although I'll happily either
> remove occurrences of it, or rewrite things as necessary.
What, you can't keep up with the thousands of changes? :) I can't either. But
yeah, according to doc/README.developer, it was deprecated sometime around
9/14/2009 r29897 when the column functions started doing the check_col() checks
internally.
> As for support for packets without the CRLF "magic number", I've never seen
> them in my traces (from various mobile phones, and a basic HSDPA modem) - but
> I'd be interested in learning how to deal with "magic-free" packets sanely.
I have a capture file I might be able to post ... I will need to scrub it first
though.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
