Wireshark-bugs: [Wireshark-bugs] [Bug 5868] USB-encapsulated AT/Hayes Commands dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 28 Apr 2011 13:08:19 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5868

Tyson Key <tyson.key@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyson.key@xxxxxxxxx

--- Comment #7 from Tyson Key <tyson.key@xxxxxxxxx> 2011-04-28 13:08:18 PDT ---
Thanks for your comments, Chris!

I'll rename the dissector "packet-at" and update various parts of it
appropriately.

As far as adding stuff to the info column is concerned, I tried a number of
approaches, although I only got as far as linefeeds being printed in one
attempt, if I remember correctly.

The header file and and external declaration are left over from the dissector
that this one was originally based upon - I'll remove them, and retest. In
fact, quite a lot is boilerplate stuff that's left over from that code.

In honesty, I've applied the patch from bug 4814) - so yes, I am using a
version of the PPP and USB dissectors with enhanced heuristics support.

I'll handle the rest of your concerns in a follow-up comment.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.