Wireshark-bugs: [Wireshark-bugs] [Bug 5854] New Dissector: Locator/ID Separation Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 28 Apr 2011 12:21:19 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5854

--- Comment #9 from Loránd Jakab <ljakab@xxxxxxxxxx> 2011-04-28 12:21:19 PDT ---
(In reply to comment #7)
> External sub-dissectors need to be called regardless of 'if(tree)'.
> 
> See section 1.2 of doc/README.developer.

IIRC, I got that 'if(tree)' from the skeleton code from section 1.2 of
doc/README.developer distributed with the 1.2.x tree, which was my starting
point back in the day. Probably there is a good reason why it was removed in
the skeleton code which is now in there, so thanks for catching it!

> 
> I've committed a change to packet-lisp.c to do so in SVN #36940.
> 
> Please review the change to make sure it's OK or to revise it if a problem or
> there's a simpler way.
> 
> (I wasn't able to test the change since the capture file doesn't have any 
> "encapsulated control messages" LISP frames).

I did a quick check with the changes, it works fine.

> 
> (I removed a XXX comment in SVN #36941; after reviewing the README.developer
> I think that calls to any external sub-dissector should be done regardless).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.