Wireshark-bugs: [Wireshark-bugs] [Bug 5828] ip.access nanoBTS vendor-specific RSL message types
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 27 Apr 2011 08:17:51 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5828

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx

--- Comment #1 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-04-27 08:17:48 PDT ---
About this array:

+               tdef = &rsl_att_tlvdef.def[tag];
+
+               switch (tdef->type) {

Not all of the entries are initialized.  That means that 'type' is going to be
0 (TLV_TYPE_FIXED) for unexpected tags.  Is that what you really want?

A common way of handling this kind of thing in Wireshark is to use
value_string-like arrays.  It means a linear search, but your list is less than
100 entries anyway...  (And it means you don't have to initialize the thing at
runtime.)

Oh, so I or others remember/notice: u_int8_t should be guint8.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.