Wireshark-bugs: [Wireshark-bugs] [Bug 5855] SVN revision 36849 crashing in packet_range_init fun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 26 Apr 2011 09:58:40 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5855

--- Comment #5 from Guy Harris <guy@xxxxxxxxxxxx> 2011-04-26 09:58:40 PDT ---
Calling cap_file_add_fdata() in process_packet() would mean that we'd be
storing frame_data structures for every frame even if we're not doing two
passes, which would be a waste of memory.

The

    for (framenum = 1; err == 0 && framenum <= cf->count; framenum++) {

        ...

    }

loop should only be happening if we're doing two passes, in which case
process_packet_first_pass() should have been called, and the extra data
structures, such as a full set of frame_data structures for every frame, should
have been set up.

The underlying problem is that we're filling in a packet range structure that

    1) can't be validly filled in if we're only making one pass through the
packets

and

    2) isn't being used in TShark in any case.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.