Wireshark-bugs: [Wireshark-bugs] [Bug 5849] msisdn_to_str() converts in loop only one byte of tv
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 19 Apr 2011 19:17:08 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5849

--- Comment #5 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-04-19 19:17:07 PDT ---
(In reply to comment #4)
> "...the seemingly arbitrary 18 BCD digits limit." I think that at least at some
> stage the maximum (E164?) B-number length was 18.

Ah, OK.  I looked at decode_gtp_msisdn(), which calls msisdn_to_str() and saw
that the length parameter being passed to it was obtained from a call to
tvb_get_ntohs(), so it looked like it could potentially be much larger than 9
bytes (18 BCD digits).

BTW, id_to_str() and imsi_to_str() could both simply be replaced with
tvb_bcd_dig_to_ep_str() too, couldn't they?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.