Wireshark-bugs: [Wireshark-bugs] [Bug 5837] Wireshark (and tshark) crashes on http traffic - dis
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5837
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-04-17 18:22:03 PDT ---
(In reply to comment #4)
> I would advocate keeping things simple: replace the NULL with ...
>
> (or maybe reverting r 36629).
The r36629 change was back-ported in order to resolve bug 5811, since it was
reported against the 1.4.x branch. There was also the following question
posted by RobB on ask.wireshark.org that might benefit from this change as
well:
http://ask.wireshark.org/questions/3323/printing-tcp-payload-using-tshark-t-fields.
Anyway, to try to accommodate the bug 5811 reporter and not force him to
upgrade to 1.5.x to obtain the functionality he desired, for now I changed the
NULL's to tvb_get_ptr()'s, which resolves this bug without having to back-port
anything else. The ultimate fix might end up being something else such as
reverting r36629 as Bill mentions, but whichever fix is chosen, at least we do
have a fix for this bug now. Unfortunately, a new Wireshark 1.4.6 release will
be needed to really fix this for the 1.4.x branch.
My sincerest apologies for my error in not noticing that passing NULL was not
possible in the 1.4.x branch.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
