Wireshark-bugs: [Wireshark-bugs] [Bug 5802] Rewrite&cleanup wiretap/file_wrappers
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 8 Apr 2011 12:37:39 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5802

--- Comment #31 from Guy Harris <guy@xxxxxxxxxxxx> 2011-04-08 12:37:39 PDT ---
OK, it fixes the "uncompression error" problem, and I saw the progress bar
weirdness without the patch, so it might be re-evaluating the size of the file
midstream (that code needs some work for a variety of reasons).

There's still the XXX comment in

        /* Well, it's not one of the types of file we know about. */
        /* XXX, free wth->fh->fast_seek */
        if (wth->random_fh != NULL)
                file_close(wth->random_fh);
        file_close(wth->fh);
        g_free(wth);
        *err = WTAP_ERR_FILE_UNKNOWN_FORMAT;
        return NULL;

Does it need to free the fast_seek stuff at that point?  If so, that needs to
be in the patch as well, so we don't leak memory.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.