Wireshark-bugs: [Wireshark-bugs] [Bug 5812] Dissector for the Babel Routing Protocol (RFC 6126)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 7 Apr 2011 17:01:16 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5812

--- Comment #12 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2011-04-07 18:01:16 MDT ---
(In reply to comment #10)
> As far as I'm aware, I'm only declaring variables at the beginning of a block,
> which is portable all the way back to C78, as opposed to declaring them in the
> middle of a block, which is indeed a C99-ism.  Do you still object to that?
> (I have no problem with changing that, I'm just confirming that we do actually
> understand each other.)

This is an example of what I saw:

           } else if(type == MESSAGE_UPDATE) {
                proto_tree *subtree;
                unsigned char p[16];
                guint8 ae = tvb_get_guint8(tvb, message + 2);

So as you stated, it probably is portable since its at the beginnings of blocks
(I wasn't paying much attention to where they were).  Thanks.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.