Wireshark-bugs: [Wireshark-bugs] [Bug 5790] Add Partial Flag and fix clang warning for Mongo Dis
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5790
--- Comment #8 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-03-31 03:08:31 PDT ---
(In reply to comment #7)
> (In reply to comment #6)
> > Hi, it is the right patch but i change also the unknown data dissect
> >
> > The part of code is fix the warning is :
> >
> > + if(offset < tvb_reported_length(tvb))
> > + {
> > + expert_add_info_format(pinfo, ti_len, PI_UNDECODED, PI_WARN, "
> > Unknown Data (not interpreted)");
> > +
>
> Ah yes, of course. But this will cause the expert info warning to be attached
> to the mongo message length field instead of to any unknown data at the end.
> If you're going to add this, then I think it would be better to attach it to
> the trailing unknown data, no?
>
> Also, in the case when the opcode falls through to the default case, you set
> the offset to the tvb_reported_length(), so in this case there's definitely
> unknown data, but the expert info warning won't be added. I don't think that
> is what we want, is it?
>
Oh yes ! it is a better idea !
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
