Wireshark-bugs: [Wireshark-bugs] [Bug 5767] Create a BitTorrent DHT dissector for wireshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 30 Mar 2011 23:35:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5767

--- Comment #12 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-03-31 08:34:50 CEST ---
Some quick review comments:
1. Please read and apply doc/README.malloc
2. Don't use C99/C++ style comments
3. Don't use C99 style log function (log10f())
4. Empty blurb in header fields should be NULL i.s.o. ""

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.