Wireshark-bugs: [Wireshark-bugs] [Bug 5753] New dissector for the openSAFETY protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 23 Mar 2011 23:59:54 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5753

--- Comment #11 from Roland Knall <rknall@xxxxxxxxx> 2011-03-23 23:59:52 PDT ---
How much d(In reply to comment #9)
> (In reply to comment #8)
> >  - fuzz testing this dissector is not necessary. The standard for openSAFETY is
> > pretty strict what you can send (even down to the small bytes in the payload).
> 
> fuzz testing's aim is to make sure that Wireshark never, ever crashes,
> regardless of what the (possibly malicious) packets look like.  (Remember that
> many users run Wireshark as root/administrator.)  To that end, fuzz testing is
> _always_ necessary.

How much difference a 

        if ( n == 0 )
            continue;

can make. Anyway, after extensive fuzzy testing with 10 different pcap files, I
can now say, the dissector has passed the fuzz test.

I have applied an updated version of the patch. Actually I changed the
crc8_opensafety method as well, but just to clarify it's operation. There was
no bug inside.

regards, Roland

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.