Wireshark-bugs: [Wireshark-bugs] [Bug 5771] Add heuristic dissector for images and HTTP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 21 Mar 2011 15:41:08 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5771

Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #2 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2011-03-21 16:41:08 MDT ---
The patch looks fine.  Is there any reason to not use tvb_memeql() instead of
tvb_strneql() with a (gchar *) cast in packet-image-png.c?  And the same in
packet-image-gif.c instead of allocating ephemeral memory for the string just
to do the comparison?  In packet-image-jfif.c, I assume that 0xFFD8 and 0xFFD9
are magic numbers for a JFIF file, right?  Maybe a #define for thosse magic
numbers and then using the name from the #define would make it clearer what it
is.  Thanks!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.