Wireshark-bugs: [Wireshark-bugs] [Bug 5752] Adding heuristic dissector code to Sercos III dissec
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 20 Mar 2011 02:04:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5752

--- Comment #4 from Roland Knall <rknall@xxxxxxxxx> 2011-03-20 02:04:01 PDT ---
(In reply to comment #3)
> That's what the code in this patch is doing, so I'll check that patch in.  The
> problem was that the openSAFETY dissector *wasn't* doing that; it was
> registering the dissector as a heuristic dissector for SERCOS III in the
> "register" routine, not in the "register handoff" routine - and that wouldn't
> even be guaranteed to work if all the dissectors were built-in; if it worked,
> it was by chance (or by alphabetical order).

The problem with that is, that if you add the heuristic dissector in openSAFETY
in the handoff routine, it still calls 

... /src/epan/packet.c:1531:heur_dissector_add: assertion failed:
(sub_dissectors ! NULL)

because the sercosiii heuristic dissector hookup is not known.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.