https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694
--- Comment #4 from Felix Kraemer <wireshark@xxxxxxxxxxxxxxxx> 2011-03-10 06:10:44 PST ---
(In reply to comment #2)
Hi Jeff, thanks for your input.
> A few comments:
>
> 1) Does this comment:
>
> - if (tree) {
> + /* The if clause needs to be commented out for
> + BACnet Statistics. However, if filtering the display,
> + the statistics trees are not created correctly, they are
> + only built to a depth of 3 or so. The relevant part for that
> + behavior is here, I believe. */
> +// if (tree) {
>
> mean that things don't work when using a display filter? That should be fixed.
This meant it. It is fixed with the newest patch I just created and attached.
>
> 2) (possibly related to (1)): Why only do this when !tree?
>
> + /* update BACnet Statistics */
> + if (!tree)
>
>
> Should it only be done on the first pass through the file? In that case,
> testing whether the packet has been seen before or not (with PINFO_FD_VISITED)
> would be a better way.
It was related to (1) indeed. Things work now without changing anything related
to the tree-stuff. I don't recall when I introduced it in my code history and
why it was necccessary, it definitely isn't anymore. So thanks for pointing me
to this issue.
>
> 3) If the header file is only used but this module (as it appears is the case),
> it doesn't need to exist; the contents should be rolled into the .c file.
It is needed by epan/wslua/taps and therefor has to exist.
Cheers,
Felix
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
