Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5654] dissector for DVB-CI (Common Interface)

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

--- Comment #18 from Martin Kaiser <wireshark@xxxxxxxxx> 2011-03-08 01:42:48 PST ---

Hello Stephen,

thanks for spotting this, it didn't show up on my linux machines (i386,
x86_64).

(In reply to comment #15)
> This patch causes a warning when compiling on Unix with gcc:
> 
> packet-dvbci.c: In function 'dissect_dvbci_lpdu':
> packet-dvbci.c:1153: warning: 'hdr_tag' may be used uninitialized in this
> function
> packet-dvbci.c:1153: note: 'hdr_tag' was declared here
> 
> I've committed SVN revision 36157 to assign hdr_tag to 0 when it is defined --
> is this a good default value to use in case dissect_dvbci_tpdu_hdr() doesn't
> assign it?

I suggest initializing hdr_tag with NO_TAG (which has the value 0), see the
attached patch.

Best regards,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.