Wireshark-bugs: [Wireshark-bugs] [Bug 5654] dissector for DVB-CI (Common Interface)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654
--- Comment #13 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-03-06 21:36:44 EST ---
Note: I took the liberty of making a few minor changes before i commited the
new dissector.
If there are any concerns as to the changes I made please let me know (or feel
free to submit a patch).
------------
- Entry for DVBCI added to wtap.c encap_table_base[];
- Some code simplification with respect to the use of col_... for COL_INFO;
- Certain tests for "enough bytes available" not really needed;
In general, the philosophy is to let the dissector error out with a
"malformed" expert message if not enough bytes are available for dissecting
a particular field; Thus,for the most part, explicit tests to determine
if enough bytes are available should not be required.
- (Other minor tweaks);
For themost part, tvb_reported_length... is used instead of tvb_length...
- #include<stdio.h> not req'd;
- Minor reformatting and whitespace cleanup;
-------------
Question: It seems to me that it might be useful to be able to filter on the
"event" field in the header. What do you think ?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
