Wireshark-bugs: [Wireshark-bugs] [Bug 4914] The packet-nbns.c dissector picks random data as the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 3 Mar 2011 12:46:36 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4914

--- Comment #6 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-03-03 15:46:30 EST ---
Stefan:


The comment just above the part of the patch shown below says "... greater then
65536 bytes...."

and yet 0x1FFFF is used for the non-SMB case.

Is this as intended ? Does the comment need to be changed ? Or what ?

+                /*
+                 * If it's SMB1 or SMB2 allow
+                 * 24 bits.
+                 */
+                max_length = 0xFFFFFF;
+            } else {
+                max_length = 0x1FFFF;
+            }
+
+            if (length > max_length)
                 goto continuation;

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.