https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5655
Bill Meier <wmeier@xxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #5897|review_for_checkin? |review_for_checkin-
Flag| |
--- Comment #7 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-02-05 13:37:03 EST ---
(From update of attachment 5897)
Note: doc/README.developer contains info relevant to most of the items below.
1. As Jaap indicated:
> It's rejected because of its errant indentation style.
- There's a mixture of 2-space, 4-space and tab indentation;
(Note: we prefer that tabs, if they are used, be 8 spaces).
2. There are lines with trailing whitespace;
3. There's a non ASCII character in the source file.
The character between the "10" and the "3" in the following:
"See Table 10–3"
4. There are patches to a number of files which would appear to have nothing to
do with CM-STATUS:
epan/dissectors/packet-zbee-zcl.h
dtds/dc.dtd
...
Submitting a patch to remove the : character from certain $ID$ statements is
OK; However please do so as a separate patch.
5. I'm a little puzzled by the TLV processing:
I get the impression that the length is the length of the value field; i.e.,
not including the T and the L bytes.
And yet: in two cases only the middle byte of what seems like a 3 byte field is
displayed;
In a third case only the first 3 bytes of what seems like a 5 byte field are
displayed.
In the fourth case only the first n-2 bytes of an n byte field are displayed.
Am I missing something ?
What is contained in the bytes not being displayed ?
6. Also: in the TLV processing nothing is displayed if there is an invalid
type. I suggest using the "expert" mechanism. (See epan/expert.h and search the
epan/dissector source for usage examples).
7. Has this dissector been fuzz-tested ?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
