Wireshark-bugs: [Wireshark-bugs] [Bug 5581] Support for additional fields in "Meta" protocol.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 14 Jan 2011 07:22:08 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5581

--- Comment #3 from Clemens Auer <auer@xxxxxx> 2011-01-14 07:22:07 PST ---
(In reply to comment #2)

> (In packet-meta.c)
> > localdevid = tvb_get_letohs(tvb, offs);
> > proto_tree_add_uint(meta_tree, hf_meta_item_localdevid, tvb, offs, 2, localdevid);
> 
> Why not use directly proto_tree_add_item ? (the localdevid variable is not used
> after..)
basically to keep the code homogeneous.
But of course it could be changed to use proto_tree_add_item for integer
fields.

> For Clemens Auer, there is no sample available for META Protocol (in Bugzilla
> or Wiki http://wiki.wireshark.org/META ) for regression test 
> There is not possible to add a sample ?
Currently I can not provide a sample because the traces we have can not be
published because of privacy issues. Probably at some time in the future we
will produce a generic trace that is ok to publish.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.