Wireshark-bugs: [Wireshark-bugs] [Bug 2254] Incorrect allocation/classification of "Type" fields
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 9 Nov 2010 12:17:29 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2254

--- Comment #9 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2010-11-09 13:17:28 MST ---
(In reply to comment #8)
> (In reply to comment #7)
> > ouch!
> 
> Hi Steve.  Any chance you might be able to finish your patch to fix this bug? 
> I looked at the patch, and just a few comments:

I'll give it another try.

> 1) Why make the "summary_in_tree" preference obsolete?  Why not just make it
> apply to all of them or none of them?

I don't remember ;)

> 2) I think the tags could use some work.  For example, for Q-in-Q tagging,
> there could be an outer tag that differs from the inner tag (e.g., 9100, 9200
> or 9300 outer tag and 8100 inner tag).  And once 802.1ad is integrated, then
> the 88a8 tag could also be present.

Ok.  I don't know anything about 802.1ad yet... 

> Only 2 years later, are you feeling the love? :)

I remember these old bugs like I just worked on them yesterday.  Remembering
why I was doing certain things on them is another story apparently :)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.