Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5367] New: VNC dissector does not properly dissect multi-segment VNC server-to

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5367

           Summary: VNC dissector does not properly dissect multi-segment
                    VNC server-to-client messages (such as framebuffer
                    updates)
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: mykaul@xxxxxxxxx


Build Information:
r34759.
--
There's more than one bug here.
First, in Hextile encoding, it does not correctly parse it - there are 16x16
tiles that need to be encoded - it seems to encode only one.
However, even if I fix it, it won't help. Although there seems to be an effort
to return needed bytes to complete the dissection back to the caller and up the
chain, it does it wrongly - as it already dissected some of the data (instead
of accumulating a complete PDU before dissecting) and it does not save state -
so it start to dissect a new PDU every packet.

The code is a bit too messy for an easy fix (at least for me).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.