Wireshark-bugs: [Wireshark-bugs] [Bug 5324] New dissector for adwin protocols
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 24 Oct 2010 18:45:58 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5324

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-10-24 18:45:55 PDT ---
Checked in with a bunch of changes (including fixing a bunch of memory leaks).

Some comments:
Why not add the 2 times in adwin-config using proto_tree_add_time() so they'll
be filterable?

You shouldn't need to set this, so I took it out:
        pinfo->current_proto = "adwin_config";

I strengthened the heuristics in adwin-config.c and made packet-adwin.c a
"new style" (semi-heuristic) dissector.  Please check my work here and if you
can think of ways to further strengthen the heuristics, please supply a patch.
(In particular the TCP heuristics in adwin-config are pretty weak.)


BTW, comment 0 mentions a bug in another dissector: did you report that?

Thanks for the contribution!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.