Wireshark-bugs: [Wireshark-bugs] [Bug 5335] Add Sockets Direct Protocol dissection to Wireshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 24 Oct 2010 01:31:27 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5335

--- Comment #3 from Slava <slavak@xxxxxxxxx> 2010-10-24 01:31:25 PDT ---
I completely agree. This is a holdover from the old code where the Infiniband
dissector did not present a public interface at all and instead used the .h
file for private definitions. It was wrong then and it's wrong now, but I was
hesitant to move several hundred lines of code into a file that's already
almost 6000 lines long.

If you say this kind of change would be preferable, I'll make the move and
submit an updated patch.

(In reply to comment #2)
> The fact that you use __IN_INIFINIBAND_DISSECTOR_ means that these parts are
> not part of the interface of the module, but integral parts of it. Hence these
> should be moved out of the header file into the module itself.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.