Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5325] New: PAP PPP Dissector Enhancement

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5325

           Summary: PAP PPP Dissector Enhancement
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: alexis.lagoutte@xxxxxxxxx


Build Information:
Shark 1.5.0 (SVN Rev 34601 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GLib 2.24.1, with libpcap 1.0.0, with libz 1.2.3.3, with
POSIX capabilities (Linux), without libpcre, with SMI 0.4.8, with c-ares 1.7.0,
with Lua 5.1, without Python, with GnuTLS 2.8.5, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP.

Running on Linux 2.6.32-21-generic, with libpcap version 1.0.0, with libz
1.2.3.3.

Built using gcc 4.4.3.

--
It is a rework of PAP PPP dissector 
- Replace proto_tree_add_text by proto_tree_add_item 
- add col_append_fstr to show information (Peer-ID, Password...)

I'm not sure if should keep check_col
  if(check_col(pinfo->cinfo, COL_INFO))
    col_add_str(pinfo->cinfo, COL_INFO,
                val_to_str(code, pap_vals, "Unknown"

The code is checked and fuzzed with PAP PPP sample from pacpr.net

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.