Wireshark-bugs: [Wireshark-bugs] [Bug 5303] Infinite loop in ZCL Discover Attributes dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 19 Oct 2010 12:01:40 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5303

--- Comment #4 from Fred Fierling <fff@xxxxxxxxxx> 2010-10-19 12:01:39 PDT ---
(In reply to comment #3)
> Just looking at line 777 it seems like this dissector could do with an owerhaul
> the whole while loop could be placed inside the if tree, couldn't it?
> 
> Possibly the check for tree could be removed from the subroutines if the check
> is done before they are called in all places.
> /Anders

It was originally written with the assumption that the subroutines would find
something interesting to display when tree == NULL. Shall we clean this up now,
or get the infinite loop fixed first?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.