Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3894] File-Open Display Filter is overwritten by Save-As Filename

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3894

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5291|review_for_checkin?         |
               Flag|                            |
   Attachment #5291|0                           |1
        is obsolete|                            |

--- Comment #9 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-10-13 20:34:00 PDT ---
Created an attachment (id=5300)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5300)
Set display filter pointers back to NULL after use.  Remove unneeded code.

(In reply to comment #8)
> Aw, man, and I thought we had found a compiler bug!
No, just my stupid mistake.  I'm thinking I probably made the code changes, got
distracted, came back and thought I had recompiled but didn't, then tested the
old code thinking I was testing the new code.  Or maybe just a lack of sleep
and C8H10N4O2?

> But then we can/should also remove the code that follows these comments:
> 
> /* Retain the filter text, and fill it in. */
> 
> since that condition will never happen.
I left that stuff in because I wasn't sure if this was the way we would go or
not and it didn't hurt to leave it there.  The attached patch removes it.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.