Wireshark-bugs: [Wireshark-bugs] [Bug 3894] File-Open Display Filter is overwritten by Save-As F
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3894
--- Comment #7 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-10-13 18:41:26 PDT ---
OK, so I rolled back all the changes to start again and apparently I messed up
during my testing regarding the idx variables and even the increase in the utf
array sizes. *sigh*.
Now I have found that if I increase the utf array by 1 from 3 to 4 that it
remedies the problem ... or so it would seem. If you open a file with a
display filter set and only do a single "File->Save As" before closing the file
and opening a new one, then the last display filter used will be shown rather
than the filename, but if you do "File->Save As" twice to 2 different files,
then we're right back where we were before.
The problem is that those utf arrays are shared and you never know when they
will be overwritten. We could increase the size of them, but I think that's
only masking the problem.
Anyway, for this bug, I think it's sufficient to resolve it by applying the
first patch I submitted (the one currently shown as obsolete, except I don't
know how to "un-obsolete" a patch), unless someone thinks it's better to
re-work the utf functions, e.g., to return some malloc'd memory that won't be
overwritten, but that the caller will then be responsible for freeing?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
