Wireshark-bugs: [Wireshark-bugs] [Bug 5286] Add support for well-known SIDs/RIDs and option to d
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5286
Cal Turney <turney_cal@xxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |turney_cal@xxxxxxx
--- Comment #4 from Cal Turney <turney_cal@xxxxxxx> 2010-10-08 16:08:17 PDT ---
(In reply to comment #3)
> (Just out of curiosity, why is DART showing SIDs differently from the way the
> company that invented them does? As I remember from my days at NetApp, Data
> ONTAP shows 'em in decimal, Microsoft-style....)
You are preaching to the choir. We have no idea why the DART developers chose
to display them in hexadecimal but it caused us a great deal of extra work
before we added the option.
> It's "hexadecimal", not "hexidecimal".
Yup, I've always misspelled that word for some reason.
>
> Why does it need to include <epan/prefs-int.h>? That's not intended for
> dissectors to include, it's only for core modules that need to know some
> internal details about how preferences are implemented. If you're doing this
> to allow multiple files to access the value of the "display in hex" preference,
> I'd just make sid_display_hex global rather than static?
I was trying to avoid making it global but I agree that it makes good sense to
do so. Yes, we do need to access sid_display_hex from some of our proprietary
plugins. I'll update them to use the global as well.
>
> Some text disappeared from a comment:
>
> - * XXX should not be letohl but native byteorder according to
> - * Samba header files.
>
> became
>
> + * XXt be letohl but native byteorder according to
> + * Samba header files.
That was unintentional. Good catch.
I'll upload the updated patch. Thanks as always, for your feedback.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
