Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5280] radiotap data rate wrong for some rates

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5280

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5276|                            |review_for_checkin?
               Flag|                            |

--- Comment #1 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-10-07 20:03:10 PDT ---
Created an attachment (id=5276)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5276)
Avoid looking up data rate via ieee80211_htrates[] array.

The attached patch seems to correct this bug, but I'm not 100% sure if it's the
right thing to do or not.  While the information at
http://www.radiotap.org/defined-fields/Rate and
http://netbsd.gw.com/cgi-bin/man-cgi?ieee80211_radiotap+9+NetBSD-current both
indicate that this is correct, the comment in the code seems to suggest that
there might be a good reason for looking up the rate if the msb is set.

Since I'm not familiar enough with radiotap to know for sure, I leave it to the
author(s) and core developers to determine if this is acceptable or not.  If it
is acceptable, then maybe the entire ieee80211_htrates[] array and if() block
at lines 992-995 should just be deleted altogether.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.