Wireshark-bugs: [Wireshark-bugs] [Bug 5270] diff for a new dissector for COAP (draft-ietf-core-c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 7 Oct 2010 17:56:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270

--- Comment #8 from Shoichi Sakane <wireshark-shoichi@xxxxxxxx> 2010-10-07 17:56:04 PDT ---

> - Terminate all value_string's with { 0, NULL }

done.

> - Use the macro MIN instead of coap_min()

just removed since I didn't use it.

> - Remove debug code

removed.

> - Don't call exit() within your code

removed.

> - Use proto_tree_add_item() instead of proto_tree_add_string with a
> tvb_get_ptr()

done.

> - You should set COL_PROTOCOL and COL_INFO even when not having parent_tree in
> dissect_coap()

I did it.  but I might be misunderstanding.  please check it.
I will post the new patch for 34419 later.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.