Wireshark-bugs: [Wireshark-bugs] [Bug 5279] Replace "Mark All Displayed Packets (toggle)" with "
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5279
--- Comment #7 from Sake <sake@xxxxxxxxxx> 2010-10-06 12:05:29 PDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > Currently mark/unmark all packets actually means mark/unmark all displayed
> > packets. I think we best keep it that way.
> >
> Actually, it doesn't. "Unmark all packets" really does unmark *ALL* packets,
> whether they are displayed or not.
r31345 | sake | 2009-12-22 08:37:00 +0100 (di, 22 dec 2009) | 3 lines
Only mark/ignore displayed frames when doing mark/ignore all packets
Looks like this was changed on purpose or broken by accident in:
r33817 | etxrab | 2010-08-16 20:17:45 +0200 (ma, 16 aug 2010) | 11 lines
>From Cal Turney:
1. Restore the functionality of <Ctrl>A and <Ctrl>X to the filter textbox.
2. Assign intuitive shortcuts without consuming any new shortcut letters.
3. Add 'Un-Time Reference All Packets' to the menu.
4. Disallow the marking or ignoring of all packets in the capture.
5. Make the Mark/Ignore/Time Reference-related menu items context sensitive.
6. Add 'ref_time_count' to the capture_file structure
7. Utilize marked/ignored/ref_time_count vars to prevent needless looping thru
the entire packet list by exiting the loop when it becomes zero.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5115
> Whichever way yields the best overall functionality and so long as it's clear
> and unambiguous as to how the packets will be marked/unmarked and to which set
> (displayed or not) it will apply.
This really needs to be unambiguous indeed... to me the current implementation
is highly confusing (and impractical)
I think there is a choice of two solutions:
Option 1:
- Mark Packet (toggle)
- Mark All Displayed Packets
- Unmark All Displayed Packets
- Invert Marking of Displayed Packets (toggle)
or
Option 2:
- Mark Packet (toggle)
- Mark All Displayed Packets
- Unmark All Displayed Packets
- Invert Marking of Displayed Packets (toggle)
- Mark All Packets
- Unmark All Packets
- Invert Marking of All Packets (toggle)
Let the voting begin :-)
I cast my vote for option 1
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
