Wireshark-bugs: [Wireshark-bugs] [Bug 5237] Forward slashes in URI need to be converted to backs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5237
--- Comment #5 from Cal Turney <turney_cal@xxxxxxx> 2010-09-28 11:34:00 PDT ---
(In reply to comment #3)
> I can reproduce the problem on Windows XP though I haven't had time to apply
> the troubleshooting patch yet.
>
> Another note: this code in gtk/menus.c:
>
> ~~~
> normalized_cf_name = g_strdup(cf_name);
> #ifdef _WIN32
> /* replace all slashes by backslashes */
> g_strdelimit(normalized_cf_name, "/", '\\');
> #endif
> ~~~
>
> also changes the slashes. I think this patch is essentially pushing that
> processing closer to where the file name comes in. I guess if we did that for
> all input sources then this menus.c code could be removed. (I don't know if
> it's worth doing that or not, it's just a thought.)
(In reply to comment #3)
> I can reproduce the problem on Windows XP though I haven't had time to apply
> the troubleshooting patch yet.
>
> Another note: this code in gtk/menus.c:
>
> ~~~
> normalized_cf_name = g_strdup(cf_name);
> #ifdef _WIN32
> /* replace all slashes by backslashes */
> g_strdelimit(normalized_cf_name, "/", '\\');
> #endif
> ~~~
>
> also changes the slashes. I think this patch is essentially pushing that
> processing closer to where the file name comes in. I guess if we did that for
> all input sources then this menus.c code could be removed. (I don't know if
> it's worth doing that or not, it's just a thought.)
Hey Jeff,
I started out using g_strdelimit() but thought it might be better to do the
conversion in dnd_uri2filename() because the intent of that routine is to
return a pathname that makes sense for and can be used on the platform being
run. Would a user or developer ever want the capture pathname in a different
format than what was opened? More important, how why would it make sense to
format the pathname differently depending on whether or not the user drops the
capture on the WS window? Seems like a bug to me. Agree?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
