Wireshark-bugs: [Wireshark-bugs] [Bug 5257] New: Improvents to hadling of gsm_um traces and diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 25 Sep 2010 11:58:11 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5257

           Summary: Improvents to hadling of gsm_um traces and dissection
                    of ccch protocol
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: wireshark@xxxxxxxxxxxxxxx


Mike Morrin <wireshark@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5216|                            |review_for_checkin?
               Flag|                            |

Created an attachment (id=5216)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5216)
patch file

Build Information:
Version 1.5.0mm_gsmtap1 (SVN Rev 34194 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.6, (32-bit) with GLib 2.22.4, with WinPcap (version
unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with
SMI
0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with
Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built
Sep
25 2010), with AirPcap.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.1
(packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729
--
In packet-gsm_a_rr.c:
* Add function to check spare bits at the end of "rest octets" for unknown
extensions.

* Around line 8600, remove 2 lines of code that were manipulating "len" for no
good reason that I could see, this code had the side effect of truncating the
dissection of all ccch PDUs by one octet.

In packet-gsm_um.c:
Change to call the ccch disector directly rather than via the dtap dissector. 
This fixes the dissection of "rest octets" which were previously ignored.

These patches can be tested with any of the traces on
https://svn.berlin.ccc.de/projects/airprobe/wiki/tracelog

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.