Wireshark-bugs: [Wireshark-bugs] [Bug 5248] New dissector for WAI authentication protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 22 Sep 2010 05:42:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5248

Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stig@xxxxxxxxxxxxx

--- Comment #2 from Stig Bjørlykke <stig@xxxxxxxxxxxxx> 2010-09-22 05:42:04 PDT ---
Some small issues:

Appending data to COL_INFO is not the way we do it, you should replace this
content (without the leading "WAY: ").


Your hf_ entries shall not have a blurb if this is equal to the name.  Set this
to NULL, e.g.:

       { &hf_wai_access_res, {"Access result", "wai.access_result", FT_UINT8,
BASE_HEX, NULL,
            0x0, "Access resulr", HFILL }},

(and you also have some typos there :)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.