Wireshark-bugs: [Wireshark-bugs] [Bug 5185] Bootp option 125 sub 5
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 18 Sep 2010 03:12:13 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5185

--- Comment #10 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2010-09-18 03:12:03 PDT ---
Hi,
+    unsigned long raw_val, i, temp;
+    int off = voff, type, flag;
Better to use glib's portable types.

+        proto_tree_add_uint_format_value()
Replace with proto_tre_add_item()
+                // /* Value(s) */
C++ style comments not alowed use /* */

proto_tree_add_boolean() could also be replaced by proto_tre_add_item()
probably proto_tree_add_string() as well.
Regards
Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.