Wireshark-bugs: [Wireshark-bugs] [Bug 5215] New: packet-flip.c: sorting by protocol column
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 14 Sep 2010 08:52:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5215

           Summary: packet-flip.c: sorting by protocol column
           Product: Wireshark
           Version: 1.5.x (Experimental)
          Platform: All
        OS/Version: Windows XP
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: juha.siltanen@xxxxxxx


Created an attachment (id=5161)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5161)
Test capture file

Build Information:
Version 1.5.0-SVN-jsl

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.6, (32-bit) with GLib 2.22.4, with WinPcap (version
unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with
SMI
0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with
Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built
Sep
14 2010), with AirPcap.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.1
(packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.

--
When sorting a capture by protocol, some RTP packets are shown only as FLIP,
even though the dissection windows shows the RTP tree. This is probably because
dissection is not asked for some packets (why only for some?), and because the
FLIP dissector sees that the tree variable is NULL, it won't call the RTP/RTCP
dissectors, and consequently, they never get a chance to write "RTP" or "RTCP"
into the protocol column.

The attached patch fixes this problem by always calling the subdissectors and
letting them decide that they don't actually have to do any work.

The patch has been fuzz-tested. The capture file used in testing is attached.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.