Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5123] New: Not all Ether-S-Bus telegrams are recognized and displayed correctl

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5123

           Summary: Not all Ether-S-Bus telegrams are recognized and
                    displayed correctly
           Product: Wireshark
           Version: 1.5.x (Experimental)
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: chrigu@xxxxxxxxxxxxxxxx


Created an attachment (id=5074)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5074)
Patch for /epan/dissectors/packet-sbus.c

Build Information:
Version 1.5.0 (SVN Rev 33734 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.8.20, (32-bit) with GLib 2.12.4, with libpcap 0.9.5, with
libz 1.2.3, without POSIX capabilities, without libpcre, without SMI, without
c-ares, without ADNS, without Lua, without Python, with GnuTLS 1.4.4, with
Gcrypt 1.2.3, without Kerberos, without GeoIP, without PortAudio, without
AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.18-6-686, with libpcap version 0.9.5, with libz 1.2.3,
GnuTLS 1.4.4, Gcrypt 1.2.3.

Built using gcc 4.1.2 20061115 (prerelease) (Debian 4.1.1-21).

Wireshark is Open Source Software released under the GNU General Public
License.

--
Sorry to bother you again... 

I corrected the following bugs in the Ether-S-Bus dissector (packet-sbus.c):
- Ether-S-Bus telegrams are not dissected if the "Ether-S-Bus version" (display
filter: sbus.vers) is 1 (which is the case on some devices supporting
Ether-S-Bus)
- Telegrams where the request telegram is not found in a conversation (not
captured or sent as IP broadcast) showed a "bad crc" because the offset is not
calculated.

With the attached capture file "Ether-S-Bus_Broadcasts.pcap" these two bugs are
reproducible. After having the patch applied, no "expert info" should be
displayed and all telegrams are dissected as Ether-S-Bus.

I've run 1000 fuzz-test runs so far. 

With best regards,
chris

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.