Wireshark-bugs: [Wireshark-bugs] [Bug 5110] Dissector of TFT - Traffic Flow Template(10.5.6.12)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5110
--- Comment #8 from jindalprateek87 <jindalprateek87@xxxxxxxxx> 2010-08-15 22:50:12 PDT ---
(In reply to comment #7)
> (In reply to comment #6)
> > Hi,
> > As far as I can tell the only "fix" missing from trunk
> > http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-gsm_a_gm.c?view=log
> > is the missing break commited in 33794. use the abov link to browse the top of
> > tree(trunk) version.
> >
> > I'll scedule the fix for 1.4.RC3 I think backporting it to 1.2 may be difficult
> > as the file has both bugfixes and features added.
> > Regards
> > Anders
>
> Hi Anders,
>
> There is another bug in the dissector for TFT Operation code = 1,3 or 4(create
> new, Add packet filters or Replace packet filters). While dissecting a Packet
> Filter Identifier in Packet Filter List, each Packet filter identifier can have
> multiple Packet filter component type identifiers(as mentioned below) in Packet
> filter contents part -
>
> Packet filter component type identifiers
>
> 0 0 0 1 0 0 0 0 IPv4 remote address type
> 0 0 1 0 0 0 0 0 IPv6 remote address type
> 0 0 1 1 0 0 0 0 Protocol identifier/Next header type
> 0 1 0 0 0 0 0 0 Single local port type
> 0 1 0 0 0 0 0 1 Local port range type
> 0 1 0 1 0 0 0 0 Single remote port type
> 0 1 0 1 0 0 0 1 Remote port range type
> 0 1 1 0 0 0 0 0 Security parameter index type
> 0 1 1 1 0 0 0 0 Type of service/Traffic class type
> 1 0 0 0 0 0 0 0 Flow label type
> REF- ETSI TS 124 008 V7.14.0 (2009-03), 3GPP TS 24.008 version 7.14.0 Release 7
>
>
> Now in case Packet filter content of the first Packet Filter Identifier
> contains 2 or more Packet filter component type identifiers, for eg - IPv4
> remote address type, Protocol identifier/Next header type and Security
> parameter index type(in that order). The dissector will only dissect(in switch
> case) the Packet filter component type identifier type IPv4 remote address and
> move ahead, incorrectly interpreting Packet filter component type identifier
> type Protocol identifier/Next header type as next Packet Filter Identifier.
>
>
> Regards,
> Prateek
> Design Engineer - Hughes Systique Corp
Hence there should be a while loop(which is commented in existing dissector)
over switch case. I have provided the correct code with the fix in my
attachments.
Regards,
Prateek
Design Engineer - Hughes Systique Corp
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
