Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5088] Further enhancement for Ether-S-Bus dissector (packet-sbus.c)

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5088

Christian Durrer <chrigu@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5018|review_for_checkin?         |
               Flag|                            |
   Attachment #5018|0                           |1
        is obsolete|                            |
   Attachment #5054|                            |review_for_checkin?
               Flag|                            |

--- Comment #4 from Christian Durrer <chrigu@xxxxxxxxxxxxxxxx> 2010-08-15 09:26:12 PDT ---
Created an attachment (id=5054)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5054)
Patch for /epan/dissectors/packet-sbus.c

Hi Anders,

you're right (as usual;-). I removed the PROTO_ITEM_SET_HIDDEN on the generated
items (I previously had them hidden in oter to have less items in the tree, but
after thinktig about it, I think it's better to have them in the tree).
The blurbs do not contain really valuable info (at least not for someone who
knows the protocol) and they are not necessary; in the readme.developer I've
seen some indication that it might be used as tooltip in future so I added them
for not having empty tooltips.

Fuzz tests are running fine (1000 runs so far), and I hope there are no stupid
errors as in my last patches...

rgds, chris

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.