https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5067
Bill Meier <wmeier@xxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
--- Comment #2 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-08-13 11:06:23 EDT ---
Some comments:
1. Zero length Content or Padding fields show as "<missing>" which seems ugly.
Suggestion: Don't show these actual fields if zero-length.
2. If there are multiple records in a frame the packet-bytes highlighting
doesn't seem to be handled correctly when selecting one of the "records" in
the packet details.
See frame #98 in the capture file.
3. I suggest adding a TCP port preference with a default of zero (as well
as doing dissector_add_handle).
This allows a user to permanently specify a TCP port in addition to using
"decode-as".
See packet-rudp.c in epan/dissectors for an example.
4. I would claim that the 'if (clen > tvblen)' and 'if (plen > tvblen)'
tests can never succeed and thus are unnecessary.
That is: since get_fcgi_record_len() uses (in effect) clen & plen to
determine the amount of data to be returned, you will always have that
amount of data when dissecting.
In addition it would be much appreciated if, at some point, you would add a
page for the FCGI protocol to the Wireshark Wiki (wiki.wireshark.org).
See: http://wiki.wireshark.org/HowToEdit
and http://wiki.wireshark.org/ProtocolReference
Thanks
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
