Wireshark-bugs: [Wireshark-bugs] [Bug 5038] Remember folder of capture selected from Welcome scr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 10 Aug 2010 12:33:29 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5038

--- Comment #8 from Cal Turney <turney_cal@xxxxxxx> 2010-08-10 12:33:24 PDT ---
(In reply to comment #7)

Thank you, Anders.  Someone replaced strncpy with g_snprintf (33759) which was
fine because it complies with the README.developer guidelines but unfortunately
introduced an 'off-by-one' error which broke the functionality along with a
syntax issue that caused a warning. Someone else eliminated the warning message
at 33760 but also did not test the functionality (at least not on a Windows
platform anyway).  

I'll upload a patch which replaces g_snprintf with g_strndup, simplifies the
code a bit, and adds a g_free.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.