Wireshark-bugs: [Wireshark-bugs] [Bug 5048] VeriWave encapsulation type and WaveAgent protocol -
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5048
--- Comment #8 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-08-10 08:07:10 CEST ---
Please be consistent: leading tabs or spaces.
I really like to see these as custom columns. We're trying hard to get the
number of columns down, and these application specific columns go right the
other way.
+static char*
+getCWstring( int control_word )
+{
+ switch (control_word)
+ {
+ case 0x01:
+ return "Receive, Count, Discard";
We've got value_strings for that, please use them.
+ else {
+ proto_tree_add_int_format(parent_tree,
+ hf_waveagent_ifwlannoise, tvb, starting_offset + 48, 4,
noise_floor,
+ "WLAN Interface Noise Floor (dBm): Not Repo
+ proto_tree_add_uint_format(waveagent_tree,
+ hf_waveagent_controlword, tvb, 30, 2, control_word, "Control
Message: %s (0x%x)",
Use proto_tree_add_int_format_value, since you only want to define the value,
not the label.
+ num_bss_entries = tvb_get_ntohl(tvb, wa_payload_offset + 8);
+
.....
+ for (iLoop = 0; iLoop < num_bss_entries; iLoop++)
+ {
What if num_bss_entries is MAX_INT? You index arrays only 8 deep with this.
Did you fuzztest this dissector enough?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
