Wireshark-bugs: [Wireshark-bugs] [Bug 5040] Optionally display Wireshark version in the main win
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 8 Aug 2010 14:49:12 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5040

--- Comment #19 from Guy Harris <guy@xxxxxxxxxxxx> 2010-08-08 14:49:04 PDT ---
I've checked in some fixes:

r33740 | guy | 2010-08-08 14:38:36 -0700 (Sun, 08 Aug 2010) | 2 lines

You can't free a string constant.

------------------------------------------------------------------------
r33739 | guy | 2010-08-08 14:26:39 -0700 (Sun, 08 Aug 2010) | 15 lines

Don't set the icon name:

        1) the GTK+ documentation recommends against it;

        2) the X11 implementation of gtk_window_set_title() sets the
           icon name to the title, so gdk_window_set_icon_name() doesn't
           do anything interesting, and the Win32 and Quartz
           implementations of gdk_window_set_icon_name() don't do
           anything;

        3) gdk_window_set_icon_name() either crashes or complains if
           it's handed a null pointer, which happens at startup.

Clean up indentation.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.