Wireshark-bugs: [Wireshark-bugs] [Bug 5051] Patch to packet_bacapp.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 26 Jul 2010 12:51:09 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5051

--- Comment #2 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-07-26 15:51:08 EDT ---
After a quick look:

I agree that body of the each of the loops is not executed when offset == 0 and
there's data remaining in the tvb.

However: The patch you propose will execute the body of each loop even if
"length_remaining" == 0.

That doesn't seem right.  :)

How about something like:

while(length_remaining > 0) {
    last_offset = offset;
    offset = ...
    if (offset == last_offset)
        break;
}


----

Do you have a capture file which shows the problem ?

If so, can you attach it (or a small subset) to this bug ?

Thanks ...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.