Wireshark-bugs: [Wireshark-bugs] [Bug 4956] The 5th dec place in all SRT dialogs is sometimes in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 8 Jul 2010 11:17:44 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4956

--- Comment #7 from Cal Turney <turney_cal@xxxxxxx> 2010-07-08 11:17:42 PDT ---
(In reply to comment #6)
> The patch rounds SRT to the nearest 1 usec.
> 
> However, the min/max times are still truncated.
> 
> I would think these times should also be rounded.
> 
> What do you think ?
> 
> g_snprintf(rp->smin,...,...,(int)rp->min.nsecs/1000)

I agree. This can be done in rpc_progs.c with:

g_snprintf(rp->smin, sizeof(rp->smin),
"%3d.%06d",(int)rp->min.secs,(int)(rp->min.nsecs+500)/1000);
g_snprintf(rp->smax, sizeof(rp->smax),
"%3d.%06d",(int)rp->max.secs,(int)(rp->max.nsecs+500)/1000);

and in service_response_time_table.c with:

rst->procedures[i].stats.min.nsecs += 500
rst->procedures[i].stats.max.nsecs += 500

I'll test these changes and upload an updated patch shortly.  I'm also make the
analogous changes for tshark.  I'll update the patches in bug#s 4915 and 4964
which also have not yet been checked in.  Thanks for the suggestion.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.