Wireshark-bugs: [Wireshark-bugs] [Bug 4984] Buildbot crash output: fuzz-2010-07-06-23547.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 7 Jul 2010 15:02:45 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4984

--- Comment #5 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-07-07 15:02:43 PDT ---
(In reply to comment #4)
> (In reply to comment #1)
> > Fixed in 33464 by making sure the offset is positive before recursing.
> 
> Jeff, is the added check sufficient in all cases?  tmp_offset += tmp_len should
> still be able to move tmp_offset back, but without making it less than offset

True; the possibility of a negative tmp_len is fixed in rev 33471.

As Gerald pointed out on -dev, we still recurse pretty deep sometimes so this
probably needs even more work...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.