Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4928] New: Please change the extern foo to WS_VAR_IMPORT foo

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4928

           Summary: Please change the extern foo to WS_VAR_IMPORT foo
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: sugyo@xxxxxxxxx


Build Information:
svn
--
Index: epan/proto.h
===================================================================
--- epan/proto.h    (revision 33329)
+++ epan/proto.h    (working copy)
@@ -1428,7 +1428,7 @@
  @param short_name abbreviated name of the new protocol
  @param filter_name protocol name used for a display filter string
  @return the new protocol handle */
-extern int
+WS_VAR_IMPORT int
 proto_register_protocol(const char *name, const char *short_name, const char
*filter_name);

 /** Mark protocol as private
@@ -1461,13 +1461,13 @@
  @param parent the protocol handle from proto_register_protocol()
  @param hf the hf_register_info array
  @param num_records the number of records in hf */
-extern void
+WS_VAR_IMPORT void
 proto_register_field_array(const int parent, hf_register_info *hf, const int
num_records);

 /** Register a protocol subtree (ett) array.
  @param indices array of ett indices
  @param num_indices the number of records in indices */
-extern void
+WS_VAR_IMPORT void
 proto_register_subtree_array(gint *const *indices, const int num_indices);

 /** Returns number of items (protocols or header fields) registered.
Index: epan/packet.h
===================================================================
--- epan/packet.h    (revision 33329)
+++ epan/packet.h    (working copy)
@@ -280,7 +280,7 @@
 extern void heur_dissector_delete(const char *name, heur_dissector_t
dissector, const int proto);

 /* Register a dissector. */
-extern void register_dissector(const char *name, dissector_t dissector,
+WS_VAR_IMPORT void register_dissector(const char *name, dissector_t dissector,
     const int proto);
 extern void new_register_dissector(const char *name, new_dissector_t
dissector,
     const int proto);
@@ -292,7 +292,7 @@
 extern int dissector_handle_get_protocol_index(const dissector_handle_t
handle);

 /* Find a dissector by name. */
-extern dissector_handle_t find_dissector(const char *name);
+WS_VAR_IMPORT dissector_handle_t find_dissector(const char *name);

 /* Create an anonymous handle for a dissector. */
 extern dissector_handle_t create_dissector_handle(dissector_t dissector,

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.