Wireshark-bugs: [Wireshark-bugs] [Bug 4887] Adding support for Gigamon headers (timestamp, sourc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 22 Jun 2010 16:29:00 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4887

--- Comment #10 from tieuthunhi <tieuthunhi@xxxxxxxxxxx> 2010-06-22 16:28:54 PDT ---
Thank you everyone for your help.  I tested revision 33271 and it looks good. 
I learn a lot looking at the latest revision.  As for the comment XXX in
packet-gmhdr.c

  if ((tvblen-5) < length)  /* XXX: Should use != length ?? */
      return 0;

You are right, a check != is more rigid.  Please check in for me.  Thank you.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.